Skip to content

VLCMain sharedInstance can recursively call itself and crash

VLCMain sharedInstance calls init in a dispatch_once, but the Video filter init done in the VLCMain init can sometimes do a resetValues call which ends up calling VLCMain sharedInstance, so it calls itself while its still doing the dispatch_once and will crash.


* thread [#1](https://code.videolan.org/videolan/vlc/-/issues/1), queue = 'com.apple.main-thread', stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
  * frame [#0](https://code.videolan.org/videolan/vlc/-/issues/0): 0x00007fff6c6cb1e1 libdispatch.dylib`_dispatch_once_wait.cold.1 + 14
    frame [#1](https://code.videolan.org/videolan/vlc/-/issues/1): 0x00007fff6c69fdcc libdispatch.dylib`_dispatch_once_wait + 93
    frame [#2](https://code.videolan.org/videolan/vlc/-/issues/2): 0x000000010b659514 libmacosx_plugin.dylib`+[VLCMain sharedInstance] [inlined] _dispatch_once(predicate=0x000000010b81adf0, block=0x000000010b659540) at once.h:84:3
    frame [#3](https://code.videolan.org/videolan/vlc/-/issues/3): 0x000000010b6594f9 libmacosx_plugin.dylib`+[VLCMain sharedInstance](self=VLCMain, _cmd="sharedInstance") at VLCMain.m:181
    frame [#4](https://code.videolan.org/videolan/vlc/-/issues/4): 0x000000010b6afeab libmacosx_plugin.dylib`-[VLCVideoEffectsWindowController resetValues](self=0x00000001005a0b80, _cmd="resetValues") at VLCVideoEffectsWindowController.m:493:47
    frame [#5](https://code.videolan.org/videolan/vlc/-/issues/5): 0x000000010b6a7179 libmacosx_plugin.dylib`-[VLCVideoEffectsWindowController init](self=0x00000001005a0b80, _cmd="init") at VLCVideoEffectsWindowController.m:95:13
    frame [#6](https://code.videolan.org/videolan/vlc/-/issues/6): 0x000000010b659903 libmacosx_plugin.dylib`-[VLCMain init](self=0x00000001004795a0, _cmd="init") at VLCMain.m:225:30
    frame [#7](https://code.videolan.org/videolan/vlc/-/issues/7): 0x000000010b65956f libmacosx_plugin.dylib`__25+[VLCMain sharedInstance]_block_invoke(.block_descriptor=0x000000010b7c2fe0) at VLCMain.m:182:26
    frame [#8](https://code.videolan.org/videolan/vlc/-/issues/8): 0x00007fff6c69f658 libdispatch.dylib`_dispatch_client_callout + 8
    frame [#9](https://code.videolan.org/videolan/vlc/-/issues/9): 0x00007fff6c6a07de libdispatch.dylib`_dispatch_once_callout + 20
    frame [#10](https://code.videolan.org/videolan/vlc/-/issues/10): 0x000000010b659514 libmacosx_plugin.dylib`+[VLCMain sharedInstance] [inlined] _dispatch_once(predicate=0x000000010b81adf0, block=0x000000010b659540) at once.h:84:3
    frame [#11](https://code.videolan.org/videolan/vlc/-/issues/11): 0x000000010b6594f9 libmacosx_plugin.dylib`+[VLCMain sharedInstance](self=VLCMain, _cmd="sharedInstance") at VLCMain.m:181
    frame [#12](https://code.videolan.org/videolan/vlc/-/issues/12): 0x000000010b659299 libmacosx_plugin.dylib`OpenIntf(p_this=0x0000000100546a70) at VLCMain.m:146:13
    frame [#13](https://code.videolan.org/videolan/vlc/-/issues/13): 0x000000010016592e libvlccore.dylib`generic_start(func=0x000000010b6591e0, forced=false, ap=0x00007ffeefbff340) at modules.c:245:11
    frame [#14](https://code.videolan.org/videolan/vlc/-/issues/14): 0x00000001001657a5 libvlccore.dylib`module_load(log=0x000000010040bca8, m=0x00000001004571b0, init=(libvlccore.dylib`generic_start at modules.c:239), forced=false, args=0x00007ffeefbff5c0) at modules.c:122:15
    frame [#15](https://code.videolan.org/videolan/vlc/-/issues/15): 0x000000010016539b libvlccore.dylib`vlc_module_load(log=0x000000010040bca8, capability="interface", name="", strict=true, probe=(libvlccore.dylib`generic_start at modules.c:239)) at modules.c:194:23
    frame [#16](https://code.videolan.org/videolan/vlc/-/issues/16): 0x0000000100165834 libvlccore.dylib`module_need(obj=0x0000000100546a70, cap="interface", name=0x0000000000000000, strict=true) at modules.c:256:24
    frame [#17](https://code.videolan.org/videolan/vlc/-/issues/17): 0x000000010016f6ce libvlccore.dylib`intf_Create(libvlc=0x000000010040bbb0, chain=0x0000000000000000) at interface.c:172:24
    frame [#18](https://code.videolan.org/videolan/vlc/-/issues/18): 0x000000010016fbaf libvlccore.dylib`libvlc_InternalAddIntf(libvlc=0x000000010040bbb0, name=0x0000000000000000) at interface.c:259:15
    frame [#19](https://code.videolan.org/videolan/vlc/-/issues/19): 0x0000000100110370 libvlc.dylib`libvlc_add_intf(p_instance=0x000000010040bb40, name=0x0000000000000000) at playlist.c:41:9
    frame [#20](https://code.videolan.org/videolan/vlc/-/issues/20): 0x000000010000360a vlc-osx-static`main(i_argc=0, ppsz_argv=0x00007ffeefbff8e8) at darwinvlc.m:271:9
    frame [#21](https://code.videolan.org/videolan/vlc/-/issues/21): 0x00007fff6c6f8cc9 libdyld.dylib`start + 1
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

VideoLAN code repository instance