Skip to content

Expose dav1d_apply_grain as part of the public API

Niklas Haas requested to merge haasn/dav1d:apply_grain_api into master

This change is motivated by a desire to be able to toggle between CPU and GPU film gain synthesis in players such as VLC. Because VLC initializes the codec before the vout (and, indeed, the active vout module may change in the middle of decoding), it cannot make the decision of whether to apply film grain in libdav1d as part of codec initialization. It needs to be decided on a frame-by-frame basis depending on whether the currently active vout supports film grain synthesis or not.

Using the new API, users like VLC can simply set apply_grain to 0 and then manually call dav1d_apply_grain whenever the vout does not support GPU film grain synthesis. As a side note, dav1d_apply_grain could also technically be called from dedicated worker threads, something that libdav1d does not currently do internally.

The alternative to this solution would have been to allow changing Dav1dSettings at runtime, but that would be more invasive and a proper API would also need to take other settings into consideration, some of which can't be changed as easily as apply_grain. This commit represents a stop-gap solution.

Merge request reports

Loading