Skip to content

Draft: Fix video resume without history

Duncan McNamara requested to merge Skantes/vlc-android:fix-resume into master

This is meant to fix several issues:

  • Restarts from the start when switching apps

This fix uses VIDEO_RESUME_TIME and VIDEO_RESUME_URI from settings.kt, but it may be a better idea to use KEY_CURRENT_MEDIA from Constants.kt, as they are used in saveCurrentMedia

  • Restarts from the start when playing again from videogrid
  • Restart from resume playback
  • Restarts without restoring playback speed

For this should also handle PlaylistManager -> restoreSpeed should use AUDIO/VIDEO_RESUME_PLAYBACK shared prefs instead of PLAYBACK_HISTORY, and keep the current playback speed in a new shared pref, but should it use VIDEO_RESUME_X or KEY_CURRENT_X. Also this means that it should be saved for current audio media which isn't the case right now.

  • Fix audio / video media same key KEY_CURRENT_MEDIA_RESUME, can cause issues at some points

This is only a guess, but I'm suspecting that this might be responsible for an elusive resume issue from the widget. Randomly while restarting playback from the widget sometimes opens up and old media (ie, opening an episode that was already watched or listened to). in PlaylistManager -> saveCurrentMedia, KEY_CURRENT_MEDIA_RESUME is saved for both video and audio

  • Ask for confirmation will pop again when switching apps
Edited by Duncan McNamara

Merge request reports

VideoLAN code repository instance