Skip to content

spectrogram: fix and improve the visualizer

Maxime Even requested to merge Maxime2/vlc-fork-for-visualizer:Xor_fixed into master

Following the compiler warning about a Xor-used-as-a-pow, I've checked if the visualizer was running normally, he was not :

audacity_sinus_440Hz.png audacity_square_440Hz.png

issue_sinus_440Hz_max_volume.png issue_square_440Hz_max_volume.png

The top screenshots are from Audacity and match the theory.

On the other hand, the two next screenshots are from the original VLC visualizer which are clearly irrelevant.

By fixing the issue, we get the following result :

fixed_sinus_440Hz_max_volume.png fixed_square_440Hz_max_volume.png

We can consider that these results match with Audacity and are correct, despite the weird-looking display of the high frequency of the squared audio. This is due to the high peak frequencies which are closer and closer and finally merge sometimes.

Merge request reports

VideoLAN code repository instance