Skip to content

qt: FirstRun dialog must be destroyed before closing the application

Pierre Lamot requested to merge chub/vlc:qt/firstrun_crash_on_close into master

FirstRun dialog used Qt::WA_DeleteOnClose, it lifecycle would be bound to the QApplication. On close the firstrun dialog will save some changes to the preferences. So we need to ensure the dialog is properly destroyed before the context becomes invalid when closing the application.

this commit updates 3895e912 which got reverted in a39d1755

Merge request reports

Loading