Skip to content

contrib: fix cddb mistakenly depending on iconv

Marvin Scholz requested to merge ePirat/vlc:epirat-contrib-fix-cddb into master

Currently there are two issues here, one hiding the other:

  • The sed pattern is wrong, causing it to not match due to leading spaces.
  • The replacement for the second sed pattern is wrong, not removing the @LIBICONV@, causing it to be present in the generated .pc, but due to the previous issue, this was hidden as the iconv detection was never actually removed.

This issue only rarely manifested, as we also build iconv in contribs, so it was totally depending on build order if this caused any issue or not.

Merge request reports

VideoLAN code repository instance