Apply rotations and flip in a single "if" statement
Sorry for the all the noise, and feel free to close without additional discussion.
In looking for the bug in #29101
I originally had trouble compiling from source on the 4.0 branch.
Eventually, i got it working and found that the 4.0 branch (master) actually has this fixed.
However, I do think the code is a bit convoluted.
In my mind:
- Read the videos settings
- Apply the correct transformations
Doesn't need an extra step of: 3. Now fixup the transformation if they are wrong.
If you do plan on closing this, I can look to backport the existing codepath in the 4.0 branch to !7113 (closed)
On master:
On this branch