Skip to content

macosx: Fix a bug preventing VLC from launching

Samuel Bassaly requested to merge sambassaly/vlc:sharedInstance_fix into master

When the defaults key VideoEffectApplyProfileOnStartup is set to true, the VLCVideoEffectsWindowController was initialized in a way that caused the VLCMain's sharedInstance method to be called recursively on launch.

This caused the app to crash, in the VLCMain's init.

The method [VLCVideoEffectsWindowController resetValues] was the source. In this fix, call this method with dispatch async, to get the sharedInstance after it is fully intitalized. This is similar to what is done in VLCAudioEffectsWindowController.

Closes #24746 (closed).

Merge request reports

VideoLAN code repository instance